chore: Add warning about implicit logical ID usage in sam build #2907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aahung
force-pushed
the
implicit-api-warning
branch
from
431f68f to
d5347fe
Compare
Contributor
|
Breadcrumb to related PR: aws/serverless-application-model#2043 |
CoshUS
approved these changes
Sep 23, 2021
hawflau
suggested changes
Sep 23, 2021
samcli/commands/build/command.py
Outdated
| build_images=processed_build_images, | ||
| aws_region=click_ctx.region, | ||
| ) as ctx: | ||
| SamApiProvider.check_implicit_api_resource_ids(ctx.stacks) |
Contributor
There was a problem hiding this comment.
Does it check whether the template is a SAM template? i.e. with Transform: AWS::Serverless-2016-10-31?
I believe SAM CLI also supports building pure CFN template. In that case, the implicit API logical IDs should not be reserved.
Contributor
There was a problem hiding this comment.
Any updates corresponding to this change request?
aahung
force-pushed
the
implicit-api-warning
branch
from
9fb9b7f to
54d6939
Compare
hawflau
approved these changes
Oct 21, 2021
aahung
force-pushed
the
implicit-api-warning
branch
from
54d6939 to
2979034
Compare
Contributor
Author
hoffa
reviewed
Jan 5, 2022
CoshUS
approved these changes
Jan 5, 2022
hawflau
approved these changes
Jan 5, 2022
Co-authored-by: Chris Rehn <crehn@outlook.com>
hoffa
approved these changes
Jan 5, 2022
mndeveci
pushed a commit
to mndeveci/aws-sam-cli
that referenced
this pull request
Apr 5, 2022
…2907) * chore: Add warning about implicit logical ID usage in sam build * Update samcli/lib/providers/sam_api_provider.py Co-authored-by: Chris Rehn <crehn@outlook.com> * Fix a smoke test case where "Transform" is not a str Co-authored-by: Chris Rehn <crehn@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
aws/serverless-application-model#2152
Why is this change necessary?
How does it address the issue?
What side effects does this change have?
Checklist
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.